Add maximize button to MutationRatesDialog#791
Merged
Conversation
Port AlienWindow's maximize behavior into AlienDialog (opt-in flag), enable it for MutationRatesDialog.
AlienWindow and AlienDialog now both call AlienGui::TitlebarMaximizeButton instead of duplicating the icon/hover-circle drawing code.
BeginPopupModal() clips widgets below its native titlebar, so the button drawn there was culled. Widen the clip rect for that call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AlienWindow's maximize icon/behavior intoAlienDialog(modal popups) as an opt-inmaximizableconstructor flag.MutationRatesDialog, adding a maximize/restore icon to its titlebar so it can fill the viewport.Test plan
build-windows-ninja.bat 16builds cleanEngineInterfaceTests.exepasses (159 tests)